Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for compile-only integration tests #50

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This PR adds a GitHub Action to invoke a compilation-only integration test every time a pull request or push is made to this repository.

NOTE: This PR does not contain any submodule hashes. It should be merged after geoschem/geos-chem#2187 is merged into dev/no-diff-to-benchmark branch.

Expected changes

This is a zero-diff update. It will cause compile-only integration tests for GCClassic to be run.

Related Github Issue(s)

@yantosca yantosca added category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking labels Mar 12, 2024
@yantosca yantosca self-assigned this Mar 12, 2024
@yantosca yantosca requested a review from msulprizio March 21, 2024 20:01
@yantosca yantosca added this to the 14.3.1 milestone Mar 21, 2024
@yantosca yantosca force-pushed the feature/compile-only-tests branch 2 times, most recently from 702de73 to cb5db03 Compare March 22, 2024 18:19
.github/workflows/gcclassic-compile-tests.yml
- Workflow YAML file that invokes a set of compile-only tests
  (i.e. integration tests with "-s none")
  NOTE: Further updates may be necessary to tweak this.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
.github/workflows/gcclassic-compile-tests.yml
- Updated the command that calls integrationTest.sh to consistent with
  geoschem/geos-chem#2187

CHANGELOG.md
- Fix typo: "integrationt" -> "integration

Signed-off-by: Bob Yantosca <[email protected]>
.github/workflows/gcclassic-compile-tests.yml
- Changed build_type to just use Debug (since the ITs require debug)
- Now use $HOME/compile-tests as the integration test folder
- Display the results.compile.log after the job finishes

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca force-pushed the feature/compile-only-tests branch from cb5db03 to ccfb727 Compare March 22, 2024 19:09
@yantosca
Copy link
Contributor Author

@yantosca yantosca merged commit 557bd53 into dev/no-diff-to-benchmark Mar 22, 2024
4 checks passed
@yantosca yantosca deleted the feature/compile-only-tests branch March 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants